fix: Disable binary_logging option as it is not valid for Postgres in…

…stances (#94)
terraform-google-modules · Apr 24, 2020 · c74b15d · c74b15d
1 parent cf87a9d
commit c74b15d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/examples/postgresql-ha/main.tf b/examples/postgresql-ha/main.tf
@@ -78,9 +78,8 @@ module "pg" {
   }
 
   backup_configuration = {
-    enabled            = true
-    binary_log_enabled = false
-    start_time         = "20:55"
+    enabled    = true
+    start_time = "20:55"
   }
 
   // Read replica configurations

diff --git a/modules/postgresql/main.tf b/modules/postgresql/main.tf
@@ -39,7 +39,7 @@ resource "google_sql_database_instance" "default" {
     dynamic "backup_configuration" {
       for_each = [var.backup_configuration]
       content {
-        binary_log_enabled = lookup(backup_configuration.value, "binary_log_enabled", null)
+        binary_log_enabled = false
         enabled            = lookup(backup_configuration.value, "enabled", null)
         start_time         = lookup(backup_configuration.value, "start_time", null)
       }

diff --git a/modules/postgresql/variables.tf b/modules/postgresql/variables.tf
@@ -119,18 +119,15 @@ variable "user_labels" {
 variable "backup_configuration" {
   description = "The backup_configuration settings subblock for the database setings"
   type = object({
-    binary_log_enabled = bool
-    enabled            = bool
-    start_time         = string
+    enabled    = bool
+    start_time = string
   })
   default = {
-    binary_log_enabled = null
-    enabled            = false
-    start_time         = null
+    enabled    = false
+    start_time = null
   }
 }
 
-
 variable "authorized_gae_applications" {
   description = "The authorized gae applications for the Cloud SQL instances"
   type        = list(string)