Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 3.2.0 #56

Closed
wants to merge 1 commit into from
Closed

chore: release 3.2.0 #56

wants to merge 1 commit into from

Conversation

release-please[bot]
Copy link
Contributor

🤖 I have created a release *beep* *boop*

3.2.0 (2021-06-25)

Features

  • Update google_compute_region_backend_service timeout to use same timeout as var.health_check (#55) (e56d959)

This PR was generated with Release Please. See documentation.

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante
Copy link
Contributor

morgante commented Jul 8, 2021

Looks like tests need to be fixed from #55:

     ×  The backend service has a timeout length of 10 seconds
     
     expected: 10
          got: 1
     
     (compared using ==)

@bharathkkb
Copy link
Member

bharathkkb commented Jul 8, 2021

@morgante should this be breaking change? If a current user has var.health_check["timeout_sec"] set, it will be overridden from 10 to that value?

@morgante
Copy link
Contributor

morgante commented Jul 8, 2021

@morgante should this be breaking change? If a current user has var.health_check["timeout_sec"] set, it will be overridden from 10 to that value?

Technically it would be, but I'm not sure this merits a breaking release since it would only impact people who have overridden the default health check.

On second though, it's probably safer if we just make this a breaking change.

@release-please release-please bot closed this Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants