Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor default google_compute_region_backend_service timeout_sec to… #55

Merged
merged 2 commits into from Jun 24, 2021
Merged

Conversation

denissimonovski
Copy link
Contributor

This allows the internal load balancer health check timeout_sec to be applied to the timeout_sec of the google_compute_region_backend_service, instead of having one hardcoded value for the latter.

Fixes #53

@denissimonovski
Copy link
Contributor Author

denissimonovski commented Jun 24, 2021

@morgante I get a permission error in the GCP account, for the int-trigger? Can you help me out with this, please?

main.tf Outdated Show resolved Hide resolved
Co-authored-by: Morgante Pell <morgante.pell@morgante.net>
@morgante morgante merged commit 0701143 into terraform-google-modules:release-v2.1.1 Jun 24, 2021
morgante added a commit that referenced this pull request Jun 25, 2021
…e timeout as var.health_check (#55)

* refactor default google_compute_region_backend_service timeout_sec to a variable

* Update main.tf

Co-authored-by: Morgante Pell <morgante.pell@morgante.net>

Co-authored-by: Denis Simonovski <denis.simonovski@rackspace.com>
Co-authored-by: Morgante Pell <morgante.pell@morgante.net>
@morgante morgante mentioned this pull request Jul 8, 2021
morgante added a commit that referenced this pull request Jul 8, 2021
BREAKING CHANGE: Backend service now inherits the same timeout used for health checks, instead of the former hardcoded value of 10 seconds.
bharathkkb pushed a commit that referenced this pull request Jul 9, 2021
BREAKING CHANGE: Backend service now inherits the same timeout used for health checks, instead of the former hardcoded value of 10 seconds.
@denissimonovski denissimonovski deleted the release-v2.1.1 branch August 5, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants