Skip to content

fix: (cli) format plugin string to snake case, closes #8017 #8149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

vasfvitor
Copy link
Contributor

@vasfvitor vasfvitor commented Nov 1, 2023

@vasfvitor vasfvitor requested a review from a team as a code owner November 1, 2023 02:21
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, Can you also add a change file in .changes directory?

@vasfvitor
Copy link
Contributor Author

vasfvitor commented Nov 7, 2023

Done. Anything else?

Should I include @tauri-apps/cli too?

@lucasfernog lucasfernog requested a review from amrbashir November 7, 2023 16:24
@lucasfernog
Copy link
Member

We actually use the heck crate to convert cases but the replace here is ok.

@vasfvitor
Copy link
Contributor Author

We actually use the heck crate to convert cases but the replace here is ok.

Thanks for mentioning it. I should've stick to my guns. I did see to_snake_case() around but didn't want to import it.

@lucasfernog lucasfernog merged commit 88dac86 into tauri-apps:dev Nov 8, 2023
@vasfvitor vasfvitor deleted the cli-snake-case branch March 3, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants