Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dialog.save return type #5373

Merged
merged 3 commits into from Oct 8, 2022
Merged

Fix dialog.save return type #5373

merged 3 commits into from Oct 8, 2022

Commits on Oct 8, 2022

  1. Fix dialog.save return type 

    Can return `null` when user cancels save dialog
    @probablykasper
    probablykasper committed Oct 8, 2022
    Copy the full SHA
    db27a7c View commit details
    Browse the repository at this point in the history

  2. Create dialog-save-return-fix.md

    @probablykasper
    probablykasper committed Oct 8, 2022
    Copy the full SHA
    d29deab View commit details
    Browse the repository at this point in the history

  3. Update tooling/api/src/dialog.ts 

    Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
    @probablykasper @FabianLars
    probablykasper and FabianLars committed Oct 8, 2022
    Copy the full SHA
    bd13f27 View commit details
    Browse the repository at this point in the history