Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dialog.save return type #5373

Merged
merged 3 commits into from Oct 8, 2022
Merged

Fix dialog.save return type #5373

merged 3 commits into from Oct 8, 2022

Conversation

probablykasper
Copy link
Member

Can return null when user cancels save dialog

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@probablykasper
Fix dialog.save return type
db27a7c 
Can return `null` when user cancels save dialog
@probablykasper probablykasper requested a review from a team as a code owner October 8, 2022 03:56
FabianLars
FabianLars requested changes Oct 8, 2022
View reviewed changes
tooling/api/src/dialog.ts Outdated Show resolved Hide resolved
@probablykasper @FabianLars
Update tooling/api/src/dialog.ts
bd13f27 
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
@lucasfernog lucasfernog merged commit 8357ce5 into dev Oct 8, 2022
@lucasfernog lucasfernog deleted the dialog-save-return-fix branch October 8, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars requested changes

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@probablykasper @lucasfernog @FabianLars