Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): run setup and window creation when event loop is ready #4914

Merged
merged 6 commits into from Aug 11, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner August 11, 2022 12:40
@lucasfernog lucasfernog changed the base branch from dev to next August 11, 2022 12:40
@amrbashir
Copy link
Member

amrbashir commented Aug 11, 2022

Doesn't this make the setup hook obsolete? because I could just do the same logic in RunEvent::Ready

@lucasfernog
Copy link
Member Author

Doesn't this make the setup hook obsolete? because I could just do the same logic in RunEvent::Ready

It does, and we might remove all of these hooks in favor of the run closure, but for now I'll avoid basic breaking changes since we're actively developing mobile.

@amrbashir
Copy link
Member

I see, but this is still a breaking change and we should note that in the change file.

@lucasfernog
Copy link
Member Author

I see, but this is still a breaking change and we should note that in the change file.

Yeah. This is the beginning of the next branch too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants