Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add mobile_entry_point macro #4983

Merged
merged 2 commits into from Aug 21, 2022
Merged

feat(core): add mobile_entry_point macro #4983

merged 2 commits into from Aug 21, 2022

Conversation

lucasfernog
Copy link
Member

@lucasfernog lucasfernog commented Aug 20, 2022 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner August 20, 2022 19:56
@lucasfernog lucasfernog changed the title refactor(app): run setup and window creation when event loop is ready (… feat(core): add mobile_entry_point macro Aug 20, 2022
@JonasKruckenberg
Copy link
Contributor

Helpppp even more macros 😂

@lucasfernog lucasfernog merged commit 9890486 into next Aug 21, 2022
@lucasfernog lucasfernog deleted the feat/mobile-entry-point-macro branch August 21, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasfernog @JonasKruckenberg