New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tauri): docs.rs build error #3974
Conversation
Can we somehow remove ayatana-tray from the default features? disabling it is kinda ugly rn |
And force everyone to pick one? |
yeah i don't know, it's tricky right now. For me on fedora i have to disable the default features and then add 4 feature flags ( As a side note we need to update the docs for that asap too (if we leave it as-is). |
Disabling it is not that bad: [dependencies]
tauri = { path = "../../../core/tauri", default-features = false, features = ["wry", "compression", "objc-exception"] }
[features]
default = [ "custom-protocol", "tauri/ayatana-tray" ]
custom-protocol = [ "tauri/custom-protocol" ]
gtk-tray = [ "tauri/gtk-tray" ] |
I thought we agreed on having ayatana-tray as a default feature since libappindicator isn't supported on newer distro releases (debian I think). |
Well maybe my actual problem here is that the tray is generally enabled by default because it never was before (it was only enabled if you had a systray config in tauri.conf.json). |
The tray isn't enabled by default. Can you share what's happening in your end? |
i get a cc linker error because ayatana is a default feature even if i don't have a systemtray configured (ayatana is also listed in the lockfile unless i disable the default features). you ofc still can't use the actual systray apis because they are behind the system-tray feature flag. |
Ahh you're right :/ I don't think we can fix it. |
Unless we force the user to pick the feature. |
Yeah i only see 3 shitty alternatives rn:
So i guess we leave it as-is for v1 and maybe consider dropping it for v2 since we need to look into changing our build tooling for new webkitgtk versions anyway where we probably end up with custom docker containers or something... linux really likes to give headaches |
Maybe we should leave the choice to the user. Currently everyone will need to have one of the libs installed in their system, even if not using the system tray feature :/ (and we also get easier toggling between gtk/ayatana since no one will need to disable default-features). |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information