Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tauri): remove ayatana-tray from the default features #3976

Merged
merged 3 commits into from Apr 26, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested review from a team April 26, 2022 21:52
@lucasfernog lucasfernog requested a review from a team as a code owner April 26, 2022 21:52
@lucasfernog
Copy link
Member Author

tl;dr ayatana-tray as a default feature forces everyone to install the package in Linux, even when not using the system-tray feature (and it's also difficult to switch to gtk-tray).
For more information see the discussion in #3974

@lucasfernog lucasfernog merged commit 62cdb2b into dev Apr 26, 2022
@lucasfernog lucasfernog deleted the refactor/ayatana-feature branch April 26, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant