Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove target triple from sidecar bin paths, closes #3355 #3356

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Remove target triple from sidecar bin paths, closes #3355 #3356

merged 2 commits into from
Feb 8, 2022

Commits on Feb 8, 2022

  1. Remove target triple from sidecar bin paths 

    Consistent with the main executable, bundled sidecar binaries
now get the original name - `my-sidecar[.exe]`.

The previous target triple resulted in an path that could not be
reconstructed at runtime if the target
was a universal binary (MacOS)

Clarified documentation on external binaries.
    @betamos
    betamos committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    69339d0 View commit details
    Browse the repository at this point in the history

  2. chore: add notice about sidecar name change [skip ci]

    @lucasfernog
    lucasfernog committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    f6678ff View commit details
    Browse the repository at this point in the history