Remove target triple from sidecar bin paths, closes #3355 #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistent with the main executable, bundled sidecar binaries now get the original name - `my-sidecar[.exe]`. The previous target triple resulted in an path that could not be reconstructed at runtime if the target was a universal binary (MacOS) Clarified documentation on external binaries.
|
It's not actually a breaking change, but I pushed a changelog entry for it just in case someone is not using our API to resolve the sidecar path. |
|
Awesome, thanks! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent with the main executable, bundled sidecar binaries
now get the original name -
my-sidecar[.exe].The previous target triple resulted in an path that could not be
reconstructed at runtime if the target
was a universal binary (MacOS)
Clarified documentation on external binaries.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information