Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Log directory #2736

Merged
merged 9 commits into from Oct 16, 2021
Merged

feat: add Log directory #2736

merged 9 commits into from Oct 16, 2021

Conversation

JonasKruckenberg
Copy link
Contributor

Adds api functions that provide access to the suggested log directory. Resolves to BaseDirectory::Home/Library/Logs/{bundle_identifier} on macOS and BaseDirectory::Config/{bundle_identifier}/logs on windows and linux.
It exposes this through tauri::api::path::BaseDirectory::Log and tauri::api::path::log_dir for rust and path.logDir for javascript.
Inspired by electrons setAppLogsPath method and the electron-log package.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner October 12, 2021 13:08
@JonasKruckenberg JonasKruckenberg requested a review from a team October 12, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants