Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log_dir #2756

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Fix log_dir #2756

merged 2 commits into from
Oct 17, 2021

Conversation

JonasKruckenberg
Copy link
Contributor

In #2736 I forgot to add log_dir to the apps PathResolver, but it makes sense to be there as it requires access to the config.
This also updates inline descriptions of the functions.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@JonasKruckenberg JonasKruckenberg added scope: api.js The @tauri-apps/api npm package api.rs scope: core Core packages of Tauri labels Oct 17, 2021
@JonasKruckenberg JonasKruckenberg requested a review from a team October 17, 2021 08:30
@lucasfernog lucasfernog merged commit 39e0da1 into next Oct 17, 2021
@lucasfernog lucasfernog deleted the fix/log_dir branch October 17, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: api.js The @tauri-apps/api npm package scope: core Core packages of Tauri
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants