Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api.js): fix os.platform return on macos and windows, closes #2698 #2699

Merged
merged 3 commits into from Oct 2, 2021
Merged

fix(api.js): fix os.platform return on macos and windows, closes #2698 #2699

merged 3 commits into from Oct 2, 2021

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Oct 2, 2021 •
edited

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team as a code owner October 2, 2021 07:19
@amrbashir amrbashir requested a review from a team October 2, 2021 07:19
@amrbashir amrbashir changed the title Fix/api/os-platform fix(api.js): fix os.platform return on macos and windows, closes #2698 Oct 2, 2021
@amrbashir @FabianLars
Update core/tauri/src/endpoin ts/operating_system.rs [skip ci]
956f831 
Co-authored-by: FabianLars <fabianlars@fabianlars.de>
@lucasfernog lucasfernog merged commit 3924c3d into next Oct 2, 2021
@lucasfernog lucasfernog deleted the fix/api/os-platform branch October 2, 2021 17:15
@FabianLars FabianLars mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars left review comments

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amrbashir @lucasfernog @FabianLars