Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core) minHeight being used as maxHeight #2247

Merged
merged 2 commits into from Jul 19, 2021
Merged

fix(core) minHeight being used as maxHeight #2247

merged 2 commits into from Jul 19, 2021

Conversation

FabianLars
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fixes the bug mentioned in tauri-apps/tao#138 (comment)

@FabianLars FabianLars requested a review from a team as a code owner July 19, 2021 16:25
@FabianLars FabianLars requested a review from a team July 19, 2021 16:25
@amrbashir
Copy link
Member

amrbashir commented Jul 19, 2021

Nice catch, I completely mis-understood the bug you mentioned, and thought it was related to the other issue, will update your comment at tao.

Co-authored-by: david <david@lemarier.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants