fix(core) minHeight being used as maxHeight (#2247)

tauri-apps · Jul 19, 2021 · e3f9916 · e3f9916
1 parent 4f88c3f
commit e3f9916
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changes/fix-min-height-typo.md b/.changes/fix-min-height-typo.md
@@ -0,0 +1,7 @@
+---
+"tauri-utils": patch
+"tauri-runtime": patch
+"tauri": patch
+---
+
+Fixes minimum window height being used as maximum height.
diff --git a/core/tauri-runtime/src/webview.rs b/core/tauri-runtime/src/webview.rs
@@ -124,7 +124,7 @@ pub trait WindowBuilder: WindowBuilderBase {
   fn min_inner_size(self, min_width: f64, min_height: f64) -> Self;
 
   /// Window max inner size.
-  fn max_inner_size(self, min_width: f64, min_height: f64) -> Self;
+  fn max_inner_size(self, max_width: f64, max_height: f64) -> Self;
 
   /// Whether the window is resizable or not.
   fn resizable(self, resizable: bool) -> Self;

diff --git a/core/tauri-utils/src/config.rs b/core/tauri-utils/src/config.rs
@@ -672,7 +672,7 @@ mod build {
       let min_width = opt_lit(self.min_width.as_ref());
       let min_height = opt_lit(self.min_height.as_ref());
       let max_width = opt_lit(self.max_width.as_ref());
-      let max_height = opt_lit(self.min_height.as_ref());
+      let max_height = opt_lit(self.max_height.as_ref());
       let resizable = self.resizable;
       let title = str_lit(&self.title);
       let fullscreen = self.fullscreen;