Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Context fields now private, Icon used on all platforms #1774

Merged
merged 7 commits into from May 11, 2021

Conversation

chippers
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Previously used #[cfg] to change the platform specific icon type, we now re-use tauri_runtime::Icon instead.

This change sets us up in the future to expand tauri::Context without breaking changes. Technically this struct was not considered part of the public api so while it's a breaking change, we never guaranteed its stability. Hopefully this change allows it to be more stable in the future, but the guarantee has not changed.

…forms

* Previously used #[cfg] to change the platform specific icon type,
we now re-use tauri_runtime::Icon instead.
@chippers chippers requested a review from a team as a code owner May 11, 2021 04:56
@chippers chippers requested a review from a team May 11, 2021 04:56
@lucasfernog lucasfernog merged commit 5542359 into dev May 11, 2021
@lucasfernog lucasfernog deleted the refactor/private-context branch May 11, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants