feat(core): finish mutable getters for Context
#1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog
reviewed
May 13, 2021
| @@ -154,24 +154,48 @@ impl<A: Assets> Context<A> { | |||
| self.assets.clone() | |||
| } | |||
|
|
|||
| /// A mutable reference to the assets to be served directly by Tauri. | |||
| #[inline(always)] | |||
| pub fn assets_mut(&mut self) -> &mut Arc<A> { | |||
There was a problem hiding this comment.
why a mutable getter for an Arc type?
There was a problem hiding this comment.
So that they can mutate the actual assets if their assets type doesn't have interior mutability. Arc provides get_mut() to turn a mutable arc into a single mutable reference
lucasfernog
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
this finishes what #1803 started, bringing mutation support back up to what it was before #1774