Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle-adjustment-in-the-large example optimization fails for larger problems #387

Closed
mariusud opened this issue Apr 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mariusud
Copy link
Contributor

mariusud commented Apr 12, 2024

Describe the bug
Hi! Running bundle-adjustment-in-the large example runs fine on the first 3 files from Trafalgar dataset, but fails when running on larger ones.
image

To Reproduce
Steps to reproduce the behavior, e.g.:

  1. Compile symforce examples and download dataset using download_dataset
  2. Run bundle-adjustment-in-the-large on problem-126 or any of the larger files

Expected behavior
The optimization to converge and return success, as it does for the smaller sized problems

Screenshots
image

Environment (please complete the following information):

  • Ubuntu 22.04.2 LTS
  • Python 3.10.12
  • SymForce Version 42c4df7
@mariusud mariusud added the bug Something isn't working label Apr 12, 2024
@rbrott
Copy link

rbrott commented May 7, 2024

The optimization goes better if you exclude the camera at index 72 for problems 126 and later (same deal with the camera at index 238 for problem 257). Camera 72 in particular seems to be poorly initialized with a position far away from the other cameras. Arguably the SymForce formulation could be made robust to this kind of outlier, though it's easy to identify and filter out prior to optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants