Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with CMake links to wrong version of fmt on Macos #346

Open
arbor-arthur opened this issue Jun 13, 2023 · 1 comment
Open

Building with CMake links to wrong version of fmt on Macos #346

arbor-arthur opened this issue Jun 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@arbor-arthur
Copy link

arbor-arthur commented Jun 13, 2023

Describe the bug
On Macos when building with cmake, if fmt version 8 and 9 (or 10) are both available, it detects version 8 and then tries to link to version 9/10, and fails because of missing symbols.

To Reproduce
Install symforce through pip, which on my computer installed fmt 8 into /Library/Frameworks/Python.framework/Versions/3.9/.
brew install fmt (for the newer version of fmt)
Download symforce v0.9.0 and follow cmake build instructions.

Expected behavior
If cmake detects version 8, it should link to the same version it finds. Alternatively, there could be an option to force downloading and linking against a local copy (what it does when it doesn't find a compatible version).

Environment (please complete the following information):

  • OS and version: Macos 13.4
  • Python version: 3.9.13
  • SymForce Version: 0.9
@arbor-arthur arbor-arthur added the bug Something isn't working label Jun 13, 2023
@chao-qu-skydio
Copy link
Contributor

I'm not sure why it would find 8 and try to link to 9 or 10, since we already restrict fmt version to only 8. If you print out some fmt cmake variables for fmt, what do they look like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants