Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skymarshal is incompatible to the latest version of ply #329

Open
KOLANICH opened this issue May 22, 2023 · 1 comment
Open

skymarshal is incompatible to the latest version of ply #329

KOLANICH opened this issue May 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@KOLANICH
Copy link

KOLANICH commented May 22, 2023

Describe the bug
In the latest version of ply API has changed (and that version is here for pretty long time). But the code in the repo (skymarshal component) still uses the API of the old version.

To Reproduce
Steps to reproduce the behavior, e.g.:

  1. git clone https://github.com/dabeaz/ply
  2. cd ply
  3. python3 -m build -nwx .
  4. sudo pip3 install --upgrade ./dist/*.whl
  5. cd ../
  6. git clone https://github.com/symforce-org/symforce
  7. cd third_party/skymarshal
  8. python3 -m buld -nwx .
  9. sudo pip3 install --upgrade ./dist/*.whl
  10. cd ../../
  11. python3 -m buld -nwx .

Expected behavior
Should be compatible to all the new and the old API of ply.

Environment (please complete the following information):

  • OS and version: Debian sid
  • Python version 3.11
  • SymForce Version c3d2f3c
@aaron-skydio
Copy link
Member

We support the latest released version of ply on PyPI that I'm aware of, which is 3.11: https://pypi.org/project/ply/#history

We'd potentially be open to also supporting from-source installs of unreleased versions of ply, or some more recent release if there is one that I'm missing, if it isn't too annoying to support both versions (I don't think we'd drop support for the released version on PyPI). We'd be happy to take a look if you want to submit a PR, I'm not really sure how involved it is to support both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants