Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API of Codegen.with_jacobians is confusing #303

Open
aaron-skydio opened this issue Feb 25, 2023 · 1 comment
Open

API of Codegen.with_jacobians is confusing #303

aaron-skydio opened this issue Feb 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@aaron-skydio
Copy link
Member

It's pretty unintuitive IMO that with_jacobians defaults to all the inputs, but the first output. I'm honestly not sure why we did this - maybe because sometimes the second output is is_valid? Even when writing this I initially wrote this issue description backwards assuming it was just the first input (because the last input is often epsilon). I think it's probably more confusing to just include the first one, and we should default to all?

Example: https://colab.research.google.com/drive/1Jm3pkngrmUxxJ5wbzBlAEJI6ERhliRTk?usp=sharing

@aaron-skydio aaron-skydio added the bug Something isn't working label Feb 25, 2023
@aaron-skydio
Copy link
Member Author

Another note here:

Also, I gave output_names which I figured would mean that those outputs get generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant