You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's pretty unintuitive IMO that with_jacobians defaults to all the inputs, but the first output. I'm honestly not sure why we did this - maybe because sometimes the second output is is_valid? Even when writing this I initially wrote this issue description backwards assuming it was just the first input (because the last input is often epsilon). I think it's probably more confusing to just include the first one, and we should default to all?
It's pretty unintuitive IMO that
with_jacobians
defaults to all the inputs, but the first output. I'm honestly not sure why we did this - maybe because sometimes the second output isis_valid
? Even when writing this I initially wrote this issue description backwards assuming it was just the first input (because the last input is often epsilon). I think it's probably more confusing to just include the first one, and we should default to all?Example: https://colab.research.google.com/drive/1Jm3pkngrmUxxJ5wbzBlAEJI6ERhliRTk?usp=sharing
The text was updated successfully, but these errors were encountered: