Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add IPv6 example for rate limit exceptions #2761

Merged
merged 1 commit into from Mar 15, 2024
Merged

[docs] Add IPv6 example for rate limit exceptions #2761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/configuration/advanced.md
View file
Open in desktop
Expand Up @@ -57,6 +57,10 @@ advanced-rate-limit-requests: 300
# applied on their requests, and rate limit headers will not be
# set for those requests.
#
# For IPv6, we only take subnets up to a /64 into account. If you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? Why?

/64 is the smallest standard subnet that’s not a single host. End users get /48 normally, or /56 if the ISP is stingy.

I think supporting a /48 should be given.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open an issue instead of commenting on a (now closed) documentation PR from a week ago please. EDIT: The PR doesn't change the behavior, it just better documents what we were already doing. If you wanna discuss changing the behavior, a new issue is the place to do it.

# want to open up a larger prefix, you'll need to list multiple
# prefixes instead.
#
# This can be useful in the following example cases (and probably
# a bunch of others as well):
#
Expand All @@ -76,7 +80,7 @@ advanced-rate-limit-requests: 300
# wide a range. If in doubt, be too restrictive rather than too
# lenient, and adjust as you go.
#
# Example: ["192.168.0.0/16"]
# Example: ["192.168.0.0/16", "2001:DB8:FACE:CAFE::/64"]
# Default: []
advanced-rate-limit-exceptions: []

Expand Down
6 changes: 5 additions & 1 deletion example/config.yaml
View file
Open in desktop
Expand Up @@ -980,6 +980,10 @@ advanced-rate-limit-requests: 300
# applied on their requests, and rate limit headers will not be
# set for those requests.
#
# For IPv6, we only take subnets up to a /64 into account. If you
# want to open up a larger prefix, you'll need to list multiple
# prefixes instead.
#
# This can be useful in the following example cases (and probably
# a bunch of others as well):
#
Expand All @@ -999,7 +1003,7 @@ advanced-rate-limit-requests: 300
# wide a range. If in doubt, be too restrictive rather than too
# lenient, and adjust as you go.
#
# Example: ["192.168.0.0/16"]
# Example: ["192.168.0.0/16", "2001:DB8:FACE:CAFE::/64"]
# Default: []
advanced-rate-limit-exceptions: []

Expand Down