Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add IPv6 example for rate limit exceptions #2761

Merged
merged 1 commit into from Mar 15, 2024

Conversation

daenney
Copy link
Member

@daenney daenney commented Mar 15, 2024

Description

  • Add IPv6 example for rate limit exceptions

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst merged commit e6e696a into main Mar 15, 2024
3 checks passed
@tsmethurst tsmethurst deleted the advanced-ratelimit-examples branch March 15, 2024 12:13
@@ -57,6 +57,10 @@ advanced-rate-limit-requests: 300
# applied on their requests, and rate limit headers will not be
# set for those requests.
#
# For IPv6, we only take subnets up to a /64 into account. If you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? Why?

/64 is the smallest standard subnet that’s not a single host. End users get /48 normally, or /56 if the ISP is stingy.

I think supporting a /48 should be given.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open an issue instead of commenting on a (now closed) documentation PR from a week ago please. EDIT: The PR doesn't change the behavior, it just better documents what we were already doing. If you wanna discuss changing the behavior, a new issue is the place to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants