Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(history): refactor restore and add tests for relations #20179

Merged
merged 10 commits into from May 6, 2024
Merged

chore(history): refactor restore and add tests for relations #20179

merged 10 commits into from May 6, 2024

Conversation

markkaylor
Copy link
Contributor

@markkaylor markkaylor commented Apr 23, 2024 •
edited

What does it do?

  • Refactors restore relations, and restore media into their own functions
  • Moves lifecycle functions into their own lifecycles service
  • Moves all history util functions to their own util factory
  • Adds api tests for restoring a history version with missing relations or media

Why is it needed?

  • To clean up the code
  • To have more test coverage

How to test it?

  • Everything should behave as expected
  • The api tests should pass

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 7:52am

@markkaylor markkaylor changed the title chore(history): add api tests chore(history): refactor restore and add tests for relations Apr 23, 2024
@markkaylor markkaylor added source: core:content-manager Source is core/content-manager package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Apr 23, 2024
@markkaylor markkaylor marked this pull request as ready for review April 23, 2024 13:49
remidej
remidej reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@remidej remidej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wonderful improvement. I hope we take the time to do the same on audit logs later

packages/core/content-manager/server/src/history/services/__tests__/history.test.ts Outdated Show resolved Hide resolved
packages/core/content-manager/server/src/history/services/history.ts Show resolved Hide resolved
tests/api/core/content-manager/content-manager/history/history.test.api.ts Show resolved Hide resolved
This was referenced Apr 24, 2024
Merged
Merged
@markkaylor markkaylor requested a review from remidej May 2, 2024 14:50
remidej
remidej approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@remidej remidej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's check the ci but lgtm

@markkaylor
Copy link
Contributor Author

Merging, the failing tests are flaky. The failing history tests are already being investigated on another branch / PR

@markkaylor markkaylor merged commit e60ec18 into v5/main May 6, 2024
79 of 83 checks passed
@markkaylor markkaylor deleted the v5/history-refactor-restore branch May 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remidej remidej remidej approved these changes

@Marc-Roig Marc-Roig Awaiting requested review from Marc-Roig

Assignees
No one assigned
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markkaylor @remidej