Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): update history api tests to created ids #20199

Merged
merged 1 commit into from Apr 24, 2024

Conversation

markkaylor
Copy link
Contributor

@markkaylor markkaylor commented Apr 24, 2024

What does it do?

Use the created versions to restore

@markkaylor markkaylor self-assigned this Apr 24, 2024
@markkaylor markkaylor added pr: fix This PR is fixing a bug source: tooling Source is GitHub tooling/tests/ect labels Apr 24, 2024
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 3:38pm

@markkaylor markkaylor merged commit bf0113b into v5/main Apr 24, 2024
80 of 85 checks passed
@markkaylor markkaylor deleted the fix/history-api-tests branch April 24, 2024 16:14
@@ -177,7 +178,7 @@ describeOnCondition(edition === 'EE')('History API', () => {
description: 'Hello',
},
}),
updateEntry({
await updateEntry({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await doesn't seem needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch I'll remove it in #20179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants