feat: add l1 transaction fee to community token contracts operations #5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
endulab
commented
Apr 18, 2024
| return res | ||
| } | ||
|
|
||
| func (s *Service) deployOwnerTokenEstimate(ctx context.Context, chainID uint64, fromAddress string, |
There was a problem hiding this comment.
The most important changes are in this file. For every operation:
- compute gas units,
- get suggested fees,
- compute l1 fee.
endulab
force-pushed
the
4351-community-token-refactoring
branch
4 times, most recently
from
5d139ac
to
2e94b07
Compare
jrainville
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
I was like "Man this PR is very big for what I thought it would be. Also some of the code feels similar to what I've seen before"
Then I saw that you were based on top of the transaction refactor, but there is a conflict right now, so it doesn't show the diff correctly, so I reviewed only the second commit
endulab
force-pushed
the
4351-community-token-refactoring
branch
from
2e94b07
to
565f8d1
Compare
endulab
force-pushed
the
4351-community-token-refactoring
branch
from
565f8d1
to
98b7a47
Compare
endulab
force-pushed
the
14166-add-l1-fees
branch
from
f06b030
to
87b89e0
Compare
Move estimation funtions to a estimations.go Compute gas, suggested fees and l1 fee in one status-go call Issue #14166
endulab
force-pushed
the
14166-add-l1-fees
branch
from
87b89e0
to
c39d1e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move estimation funtions to a estimations.go
Compute gas, suggested fees and l1 fee in one status-go call
Issue #14166