14166 add l1 fees #14621
Merged
14166 add l1 fees #14621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
saledjenic
reviewed
May 7, 2024
| @@ -1083,13 +1080,15 @@ QtObject: | |||
| let (ethCurrency, fiatCurrency) = self.create0CurrencyAmounts() | |||
| return ComputeFeeArgs(ethCurrency: ethCurrency, fiatCurrency: fiatCurrency, errorCode: errorCode) | |||
|
|
|||
| # Returns eth value with l1 fee included | |||
| proc computeEthValue(self:Service, gasUnits: int, suggestedFees: SuggestedFeesDto): float = | |||
| try: | |||
| let maxFees = suggestedFees.maxFeePerGasM | |||
| let gasPrice = if suggestedFees.eip1559Enabled: maxFees else: suggestedFees.gasPrice | |||
There was a problem hiding this comment.
This line looks misleading. I mean, how maxFeePerGasM can be used as gasPrice?
There was a problem hiding this comment.
For EIP-1559 maxFeePerGasM is the absolute maximum you are willing to pay per unit of gas to get your transaction included in a block. You are sure that you will not pay more than that.
So, I understand that you will pay no more than: gas* maxFeePerGasM
For legacy tx you just pay gas*gasPrice.
This is how I understand this.
| error "Can't find suggested fees for chainId", chainId=chainId | ||
| return | ||
| return buildTransaction(parseAddress(addressFrom), 0.u256, $gasUnits, | ||
| if suggestedFees.eip1559Enabled: "" else: $suggestedFees.gasPrice, suggestedFees.eip1559Enabled, |
There was a problem hiding this comment.
@endulab gas price should not depend on eip1559 and should not be empty.
There was a problem hiding this comment.
Why gas price is needed for eip1559 tx?
|
@endulab you're absolutely right, I overlooked something. |
saledjenic
approved these changes
May 7, 2024
jrainville
approved these changes
May 7, 2024
|
@jrainville what do you mean? |
endulab
force-pushed
the
4351-community-token-refactoring
branch
from
4313176
to
b895efa
Compare
…tions There is only one status-go call for all fees: suggested fees, gas and l1 fee. Issue #14166
endulab
force-pushed
the
14166-add-l1-fees
branch
from
93e919e
to
53cf65e
Compare
endulab
force-pushed
the
14166-add-l1-fees
branch
from
53cf65e
to
8e87fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
All fees (suggested fees, l1 fee, gas units) are computed in 1 status-go call.
Suggested fees contains correct l1 fee.
We display the cost with included l1 fee.
Related status-go pr