feat: disable language/translations selection #14539
Merged
+157
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (3)
|
caybro
force-pushed
the
14527-disable-language-selector-set-english-as-default-language-and-add-option-in-advanced-settings-to-manually-enable-its-visualization
branch
from
d76b0aa
to
89e9b28
Compare
caybro
commented
Apr 29, 2024
|
|
||
| Button { | ||
| StatusButton { |
There was a problem hiding this comment.
The main purpose here is to allow having a tooltip over a disabled (non-interactive) button
caybro
commented
Apr 29, 2024
| width: 20 | ||
| height: 20 | ||
| imgIsIdenticon: false | ||
| } | ||
|
|
||
| enum Type { | ||
| enum PickerType { |
caybro
commented
Apr 29, 2024
| y: parent.height + Style.current.padding | ||
| margins: 0 | ||
| visible: !root.languageSelectionEnabled && languagePicker.button.hovered | ||
| orientation: StatusToolTip.Orientation.Bottom |
There was a problem hiding this comment.
Can't put the tooltip above the button... the z order is totally messed up here due to bad StatusListPicker design
alexjba
approved these changes
Apr 29, 2024
- make it conditionally available for testing via Settings/Advanced/Enable translations - display a tooltip and infobox explaining the current and future situation - upon app start, force the language to "en" if the translations are not enabled; and suggest app restart when they get disabled Fixes #14527
caybro
force-pushed
the
14527-disable-language-selector-set-english-as-default-language-and-add-option-in-advanced-settings-to-manually-enable-its-visualization
branch
from
89e9b28
to
ae6c4d8
Compare
jrainville
approved these changes
Apr 29, 2024
caybro
deleted the
14527-disable-language-selector-set-english-as-default-language-and-add-option-in-advanced-settings-to-manually-enable-its-visualization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #14527
Affected areas
Settings/[Language,Advanced]
Screenshot of functionality (including design for comparison)
Defaults:
Advanced toggle:
Translations enabled:
