Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHERRY-PICK-2.28.x: feat: disable language/translations selection #14552

Merged

Conversation

caybro
Copy link
Member

@caybro caybro commented Apr 30, 2024

Cherry-pick of PR #14539

What does the PR do

  • make it conditionally available for testing via Settings/Advanced/Enable translations
  • display a tooltip and infobox explaining the current and future situation
  • upon app start, force the language to "en" if the translations are not enabled; and suggest app restart when they get disabled

Fixes #14527

Affected areas

Settings/[Language,Advanced]

- make it conditionally available for testing via
Settings/Advanced/Enable translations
- display a tooltip and infobox explaining the current and future
situation
- upon app start, force the language to "en" if the translations are not
enabled; and suggest app restart when they get disabled

Fixes #14527
@status-im-auto
Copy link
Member

status-im-auto commented Apr 30, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5c89e3a #1 2024-04-30 12:43:06 ~7 min macos/aarch64 🍎dmg
✔️ 5c89e3a #1 2024-04-30 12:45:20 ~10 min tests/nim 📄log
✔️ 5c89e3a #1 2024-04-30 12:47:32 ~12 min macos/x86_64 🍎dmg
✔️ 5c89e3a #1 2024-04-30 12:52:23 ~17 min tests/ui 📄log
✔️ 5c89e3a #1 2024-04-30 12:57:26 ~22 min linux/x86_64 📦tgz
✔️ 5c89e3a #1 2024-04-30 13:05:45 ~30 min windows/x86_64 💿exe

@caybro
Copy link
Member Author

caybro commented Apr 30, 2024

@jrainville @anastasiyaig ready to merge :)

@anastasiyaig
Copy link
Contributor

@jrainville pls force merge, tests cant pass there (known)

@jrainville jrainville merged commit f24420a into release/2.28.x Apr 30, 2024
7 of 8 checks passed
@jrainville jrainville deleted the fix/cherry-pick-14527-disable-language-selector branch April 30, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants