Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/exponentialsmoothing fit method #9129

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MarcBresson
Copy link

  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in main and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/main -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@MarcBresson MarcBresson force-pushed the doc/exponentialsmoothing-fit-method branch from 1d5c84f to 42d4f29 Compare January 24, 2024 16:21
Copy link
Member

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes would improve this. Thanks for taking a look.

statsmodels/tsa/arima/model.py Outdated Show resolved Hide resolved
statsmodels/tsa/arima/model.py Outdated Show resolved Hide resolved
fkiraly pushed a commit to sktime/sktime that referenced this pull request Mar 22, 2024
…QP (#6186)

#### Reference Issues/PRs
While exploring #6175, realized that the default parameter for `method`
in Exponential Smoothing should be `SLSQP`. This also affects
statsmodels documentation and there is already an [open
PR](statsmodels/statsmodels#9129) in their repo
to fix this.

#### What does this implement/fix? Explain your changes.
Changes docs of default `method='L-BFGS-B'` to `method='SLSQP'`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants