ENH: Add CFA to factor analysis #9114
Open
+243
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
josef-pkt
reviewed
Jan 4, 2024
| @@ -1035,3 +1088,49 @@ def load_stderr(self): | |||
|
|
|||
| v = np.outer(self.uniqueness, np.ones(self.loadings.shape[1])) | |||
| return np.sqrt(v / self.nobs) | |||
|
|
|||
| @cache_readonly | |||
| def srmr(self): | |||
There was a problem hiding this comment.
shouldn't there be another s in there: srmsr
|
That would make more sense, but it seems that srmr is what is actually
used...
…On Thu, Jan 4, 2024 at 3:18 PM Josef Perktold ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In statsmodels/multivariate/factor.py
<#9114 (comment)>
:
> @@ -1035,3 +1088,49 @@ def load_stderr(self):
v = np.outer(self.uniqueness, np.ones(self.loadings.shape[1]))
return np.sqrt(v / self.nobs)
+
+ @cache_readonly
+ def srmr(self):
shouldn't there be another s in there: srmsr
—
Reply to this email directly, view it on GitHub
<#9114 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAULBQ3MH6V26MBHOVAA4WDYM4FA7AVCNFSM6AAAAABBJSUNWWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBUHEYTAOJZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows confirmatory factor analyses to be done with the Factor class (which currently only supports exploratory factor analysis).