Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add CFA to factor analysis #9114

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

ENH: Add CFA to factor analysis #9114

wants to merge 6 commits into from

Conversation

kshedden
Copy link
Contributor

@kshedden kshedden commented Jan 2, 2024

This PR allows confirmatory factor analyses to be done with the Factor class (which currently only supports exploratory factor analysis).

@pep8speaks
Copy link

pep8speaks commented Jan 2, 2024

Hello @kshedden! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-05-05 21:00:40 UTC

@@ -1035,3 +1088,49 @@ def load_stderr(self):

v = np.outer(self.uniqueness, np.ones(self.loadings.shape[1]))
return np.sqrt(v / self.nobs)

@cache_readonly
def srmr(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't there be another s in there: srmsr

@kshedden
Copy link
Contributor Author

kshedden commented Jan 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants