Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Correct assignment in different versions of pandas #8793

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

bashtage
Copy link
Member

@bashtage bashtage commented Apr 13, 2023

Use iloc and reshaping to handle different version of pandas

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in main and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/main -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@josef-pkt
Copy link
Member

As far as I could figure out it's pandas that broke this, not scipy
#8775

The optimization looks correct but for the linear and not the affine constraint

@bashtage bashtage changed the title TST: Add conditionsl skips for scipy 1.10 BUG: Correct assignment in differetn versions of pandas Apr 13, 2023
@bashtage
Copy link
Member Author

Should be fixed now.

@bashtage bashtage changed the title BUG: Correct assignment in differetn versions of pandas BUG: Correct assignment in different versions of pandas Apr 13, 2023
Use iloc and reshaping to handle different version of pandas
@bashtage bashtage merged commit dda8e3d into statsmodels:main Apr 13, 2023
2 of 3 checks passed
@bashtage bashtage deleted the conditional-skips branch April 13, 2023 17:45
@bashtage bashtage added this to the 0.14 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG/TST: recursive_ls test failures, pandas incompatibility
2 participants