Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect dimensions in dot product #8790

Closed
wants to merge 1 commit into from
Closed

Incorrect dimensions in dot product #8790

wants to merge 1 commit into from

Conversation

DayneSorvisto
Copy link

@DayneSorvisto DayneSorvisto commented Apr 13, 2023 •
edited

No description provided.

@DayneSorvisto DayneSorvisto mentioned this pull request Apr 13, 2023
Closed
DayneSorvisto
DayneSorvisto commented Apr 13, 2023
View reviewed changes
Copy link
Author

@DayneSorvisto DayneSorvisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUG: Incompatible dimensions.

@josef-pkt
Copy link
Member

This fails in the unit test.
It looks like the original code is correct.

@bashtage
Copy link
Member

Could you explain why you think it is wrong? Perhaps your input is transposed and the code doesn't do (m)any checks?

@DayneSorvisto DayneSorvisto closed this by deleting the head repository Apr 13, 2023
@bashtage bashtage added the rejected Used for PRs with changes that are not acceptable label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rejected Used for PRs with changes that are not acceptable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DayneSorvisto @josef-pkt @bashtage