Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Cache entry uri #9844

Merged
merged 18 commits into from Apr 29, 2024
Merged

[5.x] Cache entry uri #9844

merged 18 commits into from Apr 29, 2024

Commits on Apr 8, 2024

  1. Configuration menu
    Copy the full SHA
    0cfc2e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Configuration menu
    Copy the full SHA
    74f01a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Configuration menu
    Copy the full SHA
    e1aef40 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95be09a View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    f9cffe0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e0d2e86 View commit details
    Browse the repository at this point in the history
  3. mock

    jasonvarga committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    add8255 View commit details
    Browse the repository at this point in the history
  4. compare ids since the objects arent technically identical (computedCa…

    …cheCallback property is different)
    jasonvarga committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    88d1159 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7ae2be0 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    1deddc3 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    fdc19f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bba4d75 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Fix test by moving the tag before content creation ...

    When the uri is evaluated, the parser caches the tag list. Since the tag isn't available at that point, when we try to use it in the view, it's missing.
    
    Moving the tag registration earlier makes it available when the parser does the uri. It's more reflective of a real life solution anyway. Tags would be registered early.
    jasonvarga committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6ba8099 View commit details
    Browse the repository at this point in the history
  2. ditto

    jasonvarga committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0664168 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    972ee90 View commit details
    Browse the repository at this point in the history
  4. Fix this test ...

    First of all, a slug of just a slash is a bit weird. Surprising it worked to begin with.
    Second, now that when generating the uri, it might end up reading the file again. Since the collectino created a line above requires slugs by default, it took the filename which was just the id, and used it as a slug. When we did ->get('/') it would 404 because it thinks the uri is actually /1.
    
    Easy fix is to just use an explicit not-a-slash slug.
    jasonvarga committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1a76cff View commit details
    Browse the repository at this point in the history
  5. compare ids. the objects might be have different properties - like th…

    …e computedCallbackCache for example
    jasonvarga committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f740018 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0f90874 View commit details
    Browse the repository at this point in the history