[5.x] Cache entry uri #9844
Merged
[5.x] Cache entry uri #9844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cheCallback property is different)
When the uri is evaluated, the parser caches the tag list. Since the tag isn't available at that point, when we try to use it in the view, it's missing. Moving the tag registration earlier makes it available when the parser does the uri. It's more reflective of a real life solution anyway. Tags would be registered early.
First of all, a slug of just a slash is a bit weird. Surprising it worked to begin with.
Second, now that when generating the uri, it might end up reading the file again. Since the collectino created a line above requires slugs by default, it took the filename which was just the id, and used it as a slug. When we did ->get('/') it would 404 because it thinks the uri is actually /1.
Easy fix is to just use an explicit not-a-slash slug.
…e computedCallbackCache for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to lower the overhead of getting an Entry's URI, which is currently heavy because it's built on the fly every time.
It will now Blink the URI so it's faster in the request, as well as saving it to the Stache so it doesn't have to be re-evaluated at all on subsequent requests.
I'm using a few pages of the Docs for benchmarks:
Replaces #9587