a few accessibility fixes from lighthouse report #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliff
reviewed
Dec 18, 2019
coliff
reviewed
Dec 18, 2019
squidfunk
reviewed
Dec 18, 2019
Stanzilla
commented
Dec 18, 2019
coliff
reviewed
Dec 18, 2019
squidfunk
reviewed
Dec 18, 2019
squidfunk
reviewed
Dec 18, 2019
| @@ -31,11 +31,12 @@ | |||
| <div class="md-flex__cell md-flex__cell--shrink"> | |||
| <a href="{{ config.site_url | default(nav.homepage.url, true) | url }}" | |||
| title="{{ config.site_name }}" | |||
| aria-label="{{ config.site_name }}" | |||
There was a problem hiding this comment.
Adding an ARIA label + the alt tag on the image - how is this handled by screen readers?
There was a problem hiding this comment.
The Windows Narrator just says "sitename" once.
There was a problem hiding this comment.
And lighthouse complained about there missing a label to the a because the img inside of it was not enough, for whatever reason.
There was a problem hiding this comment.
Okay great, so this is ready to merge?
There was a problem hiding this comment.
Yes from my side!
squidfunk
added a commit
that referenced
this pull request
Dec 25, 2019
* Improved Lighthouse score (#1391) * a few accessibility fixes from lighthouse report * add rel="noopener" to external links * add title attribute to social links * add mimetype to manifest link and allow it to work behind auth * add font-display: swap to all the places where external fonts are used * remove font-display: swap from icon fonts * removed font-display from style blocks in base * add target="_blank" to social links * switch base fonts grabbed from Google back to display:fallback As per recommendation from https://developers.google.com/web/updates/2016/02/font-display#fallback * add target="_blank" to the footer links as well * Set `tabindex` to `0` for skip to content link (#1393) see https://web.dev/control-focus-with-tabindex/ * Added diff to CI build * Added built files * Bump @babel/cli from 7.7.5 to 7.7.7 Bumps [@babel/cli](https://github.com/babel/babel) from 7.7.5 to 7.7.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.7.5...v7.7.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump css-loader from 3.3.2 to 3.4.0 Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.3.2 to 3.4.0. - [Release notes](https://github.com/webpack-contrib/css-loader/releases) - [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/css-loader@v3.3.2...v3.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump eslint from 6.7.2 to 6.8.0 Bumps [eslint](https://github.com/eslint/eslint) from 6.7.2 to 6.8.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v6.7.2...v6.8.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump mini-css-extract-plugin from 0.8.0 to 0.9.0 Bumps [mini-css-extract-plugin](https://github.com/webpack-contrib/mini-css-extract-plugin) from 0.8.0 to 0.9.0. - [Release notes](https://github.com/webpack-contrib/mini-css-extract-plugin/releases) - [Changelog](https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/mini-css-extract-plugin@v0.8.0...v0.9.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump @babel/plugin-transform-react-jsx from 7.7.4 to 7.7.7 Bumps [@babel/plugin-transform-react-jsx](https://github.com/babel/babel) from 7.7.4 to 7.7.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.7.4...v7.7.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump style-loader from 1.0.1 to 1.1.1 Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 1.0.1 to 1.1.1. - [Release notes](https://github.com/webpack-contrib/style-loader/releases) - [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/style-loader@v1.0.1...v1.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump webpack from 4.41.2 to 4.41.4 Bumps [webpack](https://github.com/webpack/webpack) from 4.41.2 to 4.41.4. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v4.41.2...v4.41.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump @babel/core from 7.7.5 to 7.7.7 Bumps [@babel/core](https://github.com/babel/babel) from 7.7.5 to 7.7.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.7.5...v7.7.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump @babel/preset-env from 7.7.6 to 7.7.7 Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.7.6 to 7.7.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.7.6...v7.7.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix makefile * Update packages * build * "Fix" lint * Revert icon and makefile change Co-authored-by: Martin Donath <squidfunk@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
StanzillaManticore
pushed a commit
to ManticoreGamesInc/mkdocs-material
that referenced
this pull request
Jan 1, 2020
* a few accessibility fixes from lighthouse report * add rel="noopener" to external links * add title attribute to social links * add mimetype to manifest link and allow it to work behind auth * add font-display: swap to all the places where external fonts are used * remove font-display: swap from icon fonts * removed font-display from style blocks in base * add target="_blank" to social links * switch base fonts grabbed from Google back to display:fallback As per recommendation from https://developers.google.com/web/updates/2016/02/font-display#fallback * add target="_blank" to the footer links as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per gitter