Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide an alt tag for the logo img. #1383

Closed
wants to merge 1 commit into from
Closed

Conversation

dajohi
Copy link

@dajohi dajohi commented Dec 12, 2019

No description provided.

@squidfunk
Copy link
Owner

Thanks for your PR. In both cases the logo is wrapped inside a link with title="{{ config.site_name }}", so the screen reader will most likely read out the link. IMO it makes no sense to set an alt tag here.

@Stanzilla
Copy link
Contributor

I guess it's more a out of principle thing since Google Lighthouse complains about it.

@squidfunk
Copy link
Owner

Superseded by #1391

@squidfunk squidfunk closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants