Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Editor migration missing TODOs (Editor) #22005

Merged
merged 16 commits into from
May 11, 2024
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 0 additions & 19 deletions spyder/plugins/completion/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,20 +155,6 @@ class CompletionPlugin(SpyderPluginV2):
Path to a file to open with the editor.
"""

sig_editor_rpc = Signal(str, tuple, dict)
"""
This signal is used to perform remote calls in the editor.

Parameters
----------
method: str
Name of the method to call in the editor.
args: tuple
Tuple containing the positional arguments to perform the call.
kwargs: dict
Dictionary containing the optional arguments to perform the call.
"""

sig_stop_completions = Signal(str)
"""
This signal is used to stop completion services on other Spyder plugins
Expand Down Expand Up @@ -427,11 +413,6 @@ def after_configuration_update(self, options: List[Union[tuple, str]]):
elif option_name == 'provider_configuration':
providers_to_update |= {provider_name}

# Update entries in the source menu
# FIXME: Delete this after CONF is moved to an observer pattern.
# and the editor migration starts
self.sig_editor_rpc.emit('update_source_menu', (options,), {})

def on_mainwindow_visible(self):
for provider_name in self.providers:
provider_info = self.providers[provider_name]
Expand Down
3 changes: 2 additions & 1 deletion spyder/plugins/editor/panels/scrollflag.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ def update_flags(self):

# Run this computation in a different thread to prevent freezing
# the interface
self._update_flags_thread.start()
if not self._update_flags_thread.isRunning():
self._update_flags_thread.start()

def _update_flags(self):
"""Update flags list."""
Expand Down