Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Editor migration missing TODOs (Editor) #22005

Merged
merged 16 commits into from May 11, 2024

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Apr 17, 2024

Description of Changes

TODOs follow up for #21353
Fixes #17468

TODO

  • Add public methods docstring
  • Change project active path handling (follow projects handling done over the IPython Console plugin)
  • Check specialized load methods (load_edit_goto and load_edit)
  • Move some connections logic to respective plugins on_<>_available/on_<>_teardown(Completions plugin)
  • sig_editor_rcp signal removal
  • Review config management Editor mainwidget/editorsctack registration

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@pep8speaks
Copy link

pep8speaks commented Apr 17, 2024

Hello @dalthviz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-05-10 20:28:57 UTC

@dalthviz dalthviz changed the title [WIP] PR: Add doctrings to public/API methods (Editor) [WIP] PR: Editor migration missing TODOs (Editor) Apr 23, 2024
@dalthviz dalthviz added this to the v6.0beta1 milestone Apr 23, 2024
@dalthviz dalthviz force-pushed the editor_migration_todos branch 2 times, most recently from e8a7c37 to 8ff1d87 Compare May 6, 2024 21:44
@dalthviz dalthviz changed the title [WIP] PR: Editor migration missing TODOs (Editor) PR: Editor migration missing TODOs (Editor) May 9, 2024
@dalthviz dalthviz marked this pull request as ready for review May 9, 2024 22:30
@dalthviz dalthviz requested a review from ccordoba12 May 9, 2024 22:46
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz for your work on this!

spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/main_widget.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 923ac95 into spyder-ide:master May 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor migration tracker
3 participants