Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 32: Change to plot titles displaying #35

Merged
merged 2 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# sportyR

# sportyR 2.2.1

- Faceting in `{ggplot2}` now works as expected (#27, @mrcaseb)
- Fixed link in vignette to point to POSIT, not RStudio
- Fixed [#32](https://github.com/sportsdataverse/sportyR/issues32) with plot titles not displaying correctly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the issue link for #32 is correctly formatted. It currently reads issues32 which will lead to a broken link. It should be issues/32.

- Fixed [#32](https://github.com/sportsdataverse/sportyR/issues32) with plot titles not displaying correctly
+ Fixed [#32](https://github.com/sportsdataverse/sportyR/issues/32) with plot titles not displaying correctly

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- Fixed [#32](https://github.com/sportsdataverse/sportyR/issues32) with plot titles not displaying correctly
- Fixed [#32](https://github.com/sportsdataverse/sportyR/issues/32) with plot titles not displaying correctly


# sportyR 2.2.0

Expand Down
4 changes: 2 additions & 2 deletions R/plot-helpers.R
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ create_plot_base <- function(plot_background = NULL) {
g <- ggplot2::ggplot() +
ggplot2::theme(
plot.margin = ggplot2::margin(
t = -1,
t = 0,
r = 0,
b = -1,
b = 0,
l = 0,
unit = "cm"
),
Expand Down