Issue 32: Change to plot titles displaying #35
Conversation
…wn when a display range is provided
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- R/plot-helpers.R (1 hunks)
Additional comments: 1
R/plot-helpers.R (1)
- 22-24: The adjustment of
plot.marginsettings from -1 to 0 for top (t) and bottom (b) margins in thecreate_plot_basefunction is a targeted fix to ensure plot titles are displayed correctly when a display range is specified. This change directly addresses the issue reported and follows best practices for setting margins in ggplot2 to improve plot readability and user experience.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 25 25
Lines 8410 8410
=======================================
Hits 8402 8402
Misses 8 8 ☔ View full report in Codecov by Sentry. |
| # sportyR 2.2.1 | ||
|
|
||
| - Faceting in `{ggplot2}` now works as expected (#27, @mrcaseb) | ||
| - Fixed link in vignette to point to POSIT, not RStudio | ||
| - Fixed [#32](https://github.com/sportsdataverse/sportyR/issues32) with plot titles not displaying correctly |
There was a problem hiding this comment.
Ensure the issue link for #32 is correctly formatted. It currently reads issues32 which will lead to a broken link. It should be issues/32.
- Fixed [#32](https://github.com/sportsdataverse/sportyR/issues32) with plot titles not displaying correctly
+ Fixed [#32](https://github.com/sportsdataverse/sportyR/issues/32) with plot titles not displaying correctlyCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| - Fixed [#32](https://github.com/sportsdataverse/sportyR/issues32) with plot titles not displaying correctly | |
| - Fixed [#32](https://github.com/sportsdataverse/sportyR/issues/32) with plot titles not displaying correctly |
Updated margins in create_plot_base() so that plot titles will be shown when a display range is provided per #32
Summary by CodeRabbit
{ggplot2}.