Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate when a fresh terminal is required, in the instructions. #81

Merged
merged 4 commits into from Mar 11, 2024
Merged

Indicate when a fresh terminal is required, in the instructions. #81

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5f0dd2
Update running-locally.md
tpmccallum Mar 11, 2024
59d1c3c
Update running-locally.md
tpmccallum Mar 11, 2024
e1af267
Merge branch 'main' into tpmccallum-patch-3
ThorstenHans Mar 11, 2024
d73174d
chore: Apply RuntimeClass in a new terminal instance
ThorstenHans Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions content/en/docs/spin-operator/tutorials/running-locally.md
View file
Open in desktop
Expand Up @@ -48,7 +48,7 @@ Run the following command to run the Spin Operator locally:
make run
```

Run the following command to create a Runtime Class named `wamtime-spin-v2`:
In a fresh terminal, run the following command to create a Runtime Class named `wamtime-spin-v2`:

```console
kubectl apply -f - <<EOF
Expand Down Expand Up @@ -106,7 +106,7 @@ simple-spinapp-5b8d8d69b4-snscs 1/1 Running 0 3m40s

```

Using the `NAME` from above, run the following `kubectl` command to listen on port 8083 locally and
In a fresh terminal, using the `NAME` from above, run the following `kubectl` command to listen on port 8083 locally and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required at this point, I would suggest removing this one

forward to port 80 in the pod:

```console
Expand All @@ -120,7 +120,7 @@ Forwarding from 127.0.0.1:8083 -> 80
Forwarding from [::1]:8083 -> 80
```

Run the following command, in a different terminal window:
In a fresh terminal, run the following command:

```console
curl localhost:8083/hello
Expand Down