Indicate when a fresh terminal is required, in the instructions. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Indicate where a fresh terminal is required for an upcoming command (so long-running processes can continue while new commands are run) Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
There was a problem hiding this comment.
IMO, there is one fresh terminal instance too much. Generally, we ask the user to use a new terminal instance when the previously executed command is blocking. Although, running kubectl port-forward will block the terminal, a new instance is only required for the next command (curl)
| @@ -106,7 +106,7 @@ simple-spinapp-5b8d8d69b4-snscs 1/1 Running 0 3m40s | |||
|
|
|||
| ``` | |||
|
|
|||
| Using the `NAME` from above, run the following `kubectl` command to listen on port 8083 locally and | |||
| In a fresh terminal, using the `NAME` from above, run the following `kubectl` command to listen on port 8083 locally and | |||
There was a problem hiding this comment.
This is not required at this point, I would suggest removing this one
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
`make run` is blocking the previous terminal instance, that is why we have to ask the user to use a new one Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tpmccallum tim.mccallum@fermyon.com
Indicate where a fresh terminal is required for an upcoming command (so long-running processes can continue while new commands are run)