travis: pin Node v8.x.x #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamdandelion
approved these changes
Sep 20, 2018
Summary: SourceCred officially supports Node v8.x.x, so Travis should be testing against that version of Node. This fixes a cron-only, Travis-only failure. The test for the build script asserts that stderr only contains some known expected messages. On Node v10, which Travis was using, there is an additional deprecation message due to <yarnpkg/yarn#5477>. Test Plan: To see that this fixes the current cron-only build failure, add the `--full` argument to the `test` script in `package.json`, and push the resulting tree to Travis. Note that it runs `sharness-full`, which passes. wchargin-branch: travis-node-8
wchargin
force-pushed
the
wchargin-travis-node-8
branch
from
08c895d
to
1ee706a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SourceCred officially supports Node v8.x.x, so Travis should be testing
against that version of Node.
This fixes a cron-only, Travis-only failure. The test for the build
script asserts that stderr only contains some known expected messages.
On Node v10, which Travis was using, there is an additional deprecation
message due to yarnpkg/yarn#5477.
Test Plan:
To see that this fixes the current cron-only build failure, add the
--fullargument to thetestscript inpackage.json, and push theresulting tree to Travis. Note that it runs
sharness-full, whichpasses.
wchargin-branch: travis-node-8