Skip to content

Commit

Permalink
travis: pin Node v8.x.x (#867)
Browse files Browse the repository at this point in the history
Summary:
SourceCred officially supports Node v8.x.x, so Travis should be testing
against that version of Node.

This fixes a cron-only, Travis-only failure. The test for the build
script asserts that stderr only contains some known expected messages.
On Node v10, which Travis was using, there is an additional deprecation
message due to <yarnpkg/yarn#5477>.

Test Plan:
To see that this fixes the current cron-only build failure, add the
`--full` argument to the `test` script in `package.json`, and push the
resulting tree to Travis. Note that it runs `sharness-full`, which
passes.

wchargin-branch: travis-node-8
  • Loading branch information
wchargin committed Sep 20, 2018
1 parent 778ce9e commit ac46a98
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
@@ -1,6 +1,6 @@
language: node_js
node_js:
- "node"
- "8"
script: yarn test
notifications:
email:
Expand Down

0 comments on commit ac46a98

Please sign in to comment.