Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated alpine to the latest version (3.13.10) #14700

Merged
merged 1 commit into from May 15, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

In order to get the label preview working for anything past 3.13.5 I needed to change the toString method name . I'm thinking Alpine started taking over that method in 3.13.6 (I didn't dig too deeply).

I'm opening this as a draft for now pending more local testing.

I'm targeting develop but can move it to the v7 branch if needed.

Type of change

  • Dependency update

Includes fix to new label engine.
@marcusmoore marcusmoore requested a review from snipe as a code owner May 8, 2024 00:20
@probot-autolabeler probot-autolabeler bot added dependencies Pull requests that update a dependency file frontend javascript labels May 8, 2024
Copy link

what-the-diff bot commented May 8, 2024

PR Summary

  • Update of alpinejs version in package-lock.json and package.json
    The version of alpinejs used in our application has been updated from 3.13.5 to 3.13.10. This could provide improvements or bug fixes in the library.

  • Modifying valueString function in resources/views/partials/label2-field-definitions.blade.php
    The valueString function was modified to use a new function namely getCombinedString. This new implementation helps to concatenate fields and options more effectively.

  • Logging feature added to onTest function
    A new feature was added to the onTest function which logs a message every time it's executed. This can aid in the function's debugging and understanding its usage patterns.

  • Enhancements to addToFields and move functions
    The addToFields and move functions are now equipped to handle nested fields. This extends the versatility of our field manipulation capabilities.

  • toString function transition to getCombinedString
    The toString function has been updated to getCombinedString. This modification is meant to increase clarity and understanding of the operation this function performs.

@marcusmoore marcusmoore marked this pull request as draft May 9, 2024 16:50
@marcusmoore marcusmoore marked this pull request as ready for review May 9, 2024 17:52
@marcusmoore
Copy link
Collaborator Author

Did some testing and this looks good for review 👍🏾

@snipe snipe merged commit 30f7386 into snipe:develop May 15, 2024
8 checks passed
@snipe
Copy link
Owner

snipe commented May 15, 2024

Excellent catch! TY!

@marcusmoore marcusmoore deleted the chore/sc-25471 branch May 15, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants