New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADDED: Export User Permissions (Superuser & Admin) #14614
base: develop
Are you sure you want to change the base?
Conversation
PR Summary
|
Looks like we have some conflicts here - can you resolve those? Also, I don't think we specify anything other than admin or superadmin, right? That could be misleading, since it could appear as though the user has no extra privileges even when they might be able to edit/create users, assets, etc. Not sure the best way to handle that issue. |
yes, there are other permissions. We DID tho in our dev meeting on a monday say to start with only admin and superuser. |
Alison says - for people who have at least some privileges - make sure to show something in there. Alison says "*" but I would prefer something like "normal permissions" or something like that? |
We can do this, but for this particular solve, since we are specifically looking for the admin or superuser key value pair, we either can |
Description
A new column has been added to the users export. When exporting using the
Export
button on the users index page, Superusers and Admins will be listed as such.Fixes # SC-19796
Type of change
New feature (non-breaking change which adds functionality)
I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes