-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add no-interactive flag for upgrade.php
#14578
Conversation
💖 Thanks for this pull request! 💖 We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
PR Summary
|
Hey there - can you retarget this to |
Having a no-interactive flag is useful because attempting to automate snipe-it upgrades is currently extremely janky. You have to either: a) read the prompts and pass in the input (the "correct" way) b) pipe in input, e.g. `yes` and hope no new prompts are added. With the `no-interactive` flag, this can be fixed by both allowing new prompts to be added without conflict to user prompts, but also allowing automated upgrades (you could choose to crash, or assign defaults).
65c0d2c
to
20920c2
Compare
Apologies, should be on |
Congrats on merging your first pull request! 🎉🎉🎉 |
Hello, I would like to use this feature to automate my SnipeIT updates, but unfortunately the argument does not work properly for me |
@kurthuber-dev did you try doing a |
now it works, thanks a lot |
Having a no-interactive flag is useful because attempting to automate snipe-it upgrades is currently very janky. You have to either:
a) read the prompts and pass in the input (the "correct" way)
a) pipe in input, e.g.
yes
and hope no new prompts are added.With a
no-interactive
flag, this can be fixed by both allowing new prompts to be added without conflictto user prompts, but also allowing automated upgrades (you could choose to crash, or assign defaults).
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context, providing screenshots where practical. List any dependencies that are required for this change.
Feature addition to
upgrade.php
, no issue found that could be relevant in fixing.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
upgrade.php
andupgrade.php --no-interactive
on any SnipeIT supported php version.--no-interactive
runs the upgrade without needing the confirmation prompt.Test Configuration:
Checklist: